Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 as the minimum-supported Python version #2567

Merged
merged 16 commits into from
Oct 11, 2022

Conversation

davep
Copy link
Contributor

@davep davep commented Oct 10, 2022

Implements the requirements outlined in #2566.

Addressing Textualize#2468; before this change the tag-matching code was non-greedy,
resulting in an unbalanced match if there were tags within tags. This
change makes this greedy to ensure that there's a better chance of the match
being balanced.
Python 3.7 is now our minimum-supported Python, and so we don't need to pull
in dataclasses any more.

See Textualize#2566.
Python 3.7 is now our minimum-supported Python, and so we don't need to add
our own version of isascii any more.

See Textualize#2566.
Python 3.7 is now our minimum-supported Python, and so we don't need to add
these properties any more.

See Textualize#2566.
The minimum-supported Python has changed from 3.6.x to 3.7. See Textualize#2566.
@davep davep self-assigned this Oct 10, 2022
@davep davep changed the title Drop Python 3.6 as the minimum-supported Python versn Drop Python 3.6 as the minimum-supported Python version Oct 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 98.39% // Head: 98.39% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4d084d5) compared to base (6e953c6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2567      +/-   ##
==========================================
- Coverage   98.39%   98.39%   -0.01%     
==========================================
  Files          63       63              
  Lines        6806     6797       -9     
==========================================
- Hits         6697     6688       -9     
  Misses        109      109              
Flag Coverage Δ
unittests 98.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/_null_file.py 100.00% <ø> (ø)
rich/rule.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davep
Copy link
Contributor Author

davep commented Oct 11, 2022

This would seem to 100% deserve an entry in the CHANGELOG; need to have a wee chat about how and when to update the CHANGELOG.

@davep davep mentioned this pull request Oct 11, 2022
9 tasks
@davep davep linked an issue Oct 11, 2022 that may be closed by this pull request
7 tasks
@davep
Copy link
Contributor Author

davep commented Oct 11, 2022

Annoyingly I just noticed that I managed to start this branch from code that had already had ce55112 applied -- this wasn't my intention. This means that this PR overlaps with #2565

In discussion with Will it seemed clear that documenting this doesn't really
help anyone, and anyone it could possibly affect would be more affected by
the dropping of Python 3.6 as a supported Python version.
@davep
Copy link
Contributor Author

davep commented Oct 11, 2022

ChangeLog tweaks made as per review.

@davep davep merged commit 234d1ea into Textualize:master Oct 11, 2022
@hugovk hugovk mentioned this pull request Oct 11, 2022
8 tasks
@davep davep deleted the drop-python36 branch October 11, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.6 as a supported version of Python
3 participants